r49323 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49322‎ | r49323 | r49324 >
Date:21:05, 8 April 2009
Author:aaron
Status:ok
Tags:
Comment:
(bug 18167) Code Review page should not render magic words etc.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReleaseNotes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReleaseNotes.php
@@ -55,7 +55,7 @@
5656
5757 protected function showReleaseNotes() {
5858 global $wgOut;
59 - $linker = new CodeCommentLinkerWiki( $this->mRepo );
 59+ $linker = new CodeCommentLinkerHtml( $this->mRepo );
6060 $dbr = wfGetDB( DB_SLAVE );
6161 if ( $this->mEndRev ) {
6262 $where = 'cr_id BETWEEN ' . intval( $this->mStartRev ) . ' AND ' . intval( $this->mEndRev );
@@ -93,9 +93,10 @@
9494 if ( $summary ) {
9595 $summary = str_replace( "\n", "<br/>", $summary ); // Newlines -> <br/>
9696 $wgOut->addHTML( "<li>" );
97 - $wikiText = $linker->link( $summary ) . " ''(" . htmlspecialchars( $row->cr_author ) .
98 - ', ' . $linker->link( "r{$row->cr_id}" ) . ")''";
99 - $wgOut->addWikiText( $wikiText, false );
 97+ $wgOut->addHTML(
 98+ $linker->link( $summary ) . " <i>(" . htmlspecialchars( $row->cr_author ) .
 99+ ', ' . $linker->link( "r{$row->cr_id}" ) . ")</i>"
 100+ );
100101 $wgOut->addHTML( "</li>\n" );
101102 }
102103 }

Status & tagging log