r49210 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49209‎ | r49210 | r49211 >
Date:14:02, 5 April 2009
Author:ialex
Status:ok
Tags:
Comment:
Don't display the "noautoblock" flag when blocking an IP address since this option is not displayed in the block form.

Thanks to Elfix on the French Wikipedia for the report.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -598,7 +598,8 @@
599599 $flags[] = 'anononly';
600600 if( $this->BlockCreateAccount )
601601 $flags[] = 'nocreate';
602 - if( !$this->BlockEnableAutoblock )
 602+ if( !$this->BlockEnableAutoblock && !IP::isIPAddress( $this->BlockAddress ) )
 603+ // Same as anononly, this is not displayed when blocking an IP address
603604 $flags[] = 'noautoblock';
604605 if ( $this->BlockEmail )
605606 $flags[] = 'noemail';
Index: trunk/phase3/RELEASE-NOTES
@@ -324,6 +324,8 @@
325325 * Fixed a PHP notice when $wgEnableSerializedMessages was set to false
326326 * (bug 18316) Removed superfluous name="fulltext" from Special:Search
327327 * (bug 18331) MediaWiki:Undelete-revision can now have wikitext
 328+* The "noautoblock" flag is no longer displayed in the block log when blocking
 329+ an IP address
328330
329331 == API changes in 1.15 ==
330332 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Status & tagging log