r49194 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49193‎ | r49194 | r49195 >
Date:02:37, 5 April 2009
Author:aaron
Status:ok
Tags:
Comment:
Clean up ipb_deleted query slightly
Modified paths:
  • /trunk/phase3/includes/specials/SpecialListusers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListusers.php
@@ -74,7 +74,7 @@
7575 $dbr = wfGetDB( DB_SLAVE );
7676 $conds = array();
7777 // Don't show hidden names
78 - $conds[] = 'ipb_deleted IS NULL OR ipb_deleted = 0';
 78+ $conds[] = 'ipb_deleted IS NULL';
7979 if( $this->requestedGroup != '' ) {
8080 $conds['ug_group'] = $this->requestedGroup;
8181 $useIndex = '';
@@ -97,7 +97,7 @@
9898
9999 $query = array(
100100 'tables' => " $user $useIndex LEFT JOIN $user_groups ON user_id=ug_user
101 - LEFT JOIN $ipblocks ON user_id=ipb_user AND ipb_auto=0 ",
 101+ LEFT JOIN $ipblocks ON user_id=ipb_user AND ipb_deleted=1 AND ipb_auto=0 ",
102102 'fields' => array(
103103 $this->creationSort ? 'MAX(user_name) AS user_name' : 'user_name',
104104 $this->creationSort ? 'user_id' : 'MAX(user_id) AS user_id',

Status & tagging log