r49182 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49181‎ | r49182 | r49183 >
Date:18:45, 4 April 2009
Author:ialex
Status:deferred
Tags:
Comment:
Settings that weren't taken into account when using database handler with $wgConfigureAllowDeferSetup = true are now ignored with that configuration
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/Configure.handler-db.php (modified) (history)
  • /trunk/extensions/Configure/Configure.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/CHANGELOG
@@ -1,6 +1,10 @@
22 This file lists changes on this extension.
33 Localisation updates are done on betawiki and aren't listed here.
44
 5+0.13.9 - 4 April 2009
 6+ Settings that weren't taken into account when using database handler with
 7+ $wgConfigureAllowDeferSetup = true are now ignored with that configuration.
 8+
59 0.13.8 - 1 April 2009
610 Added $wgUseImageResize, $wgCopyUploadTimeout, $wgInvalidUsernameCharacters
711 and $wgUserrightsInterwikiDelimiter.
Index: trunk/extensions/Configure/Configure.handler-db.php
@@ -323,7 +323,9 @@
324324 * Get settings that are not editable with the database handler
325325 */
326326 public function getUneditableSettings() {
327 - return array(
 327+ global $wgConfigureAllowDeferSetup;
 328+
 329+ $uneditable = array(
328330 # Database
329331 'wgAllDBsAreLocalhost',
330332 'wgCheckDBSchema',
@@ -356,5 +358,38 @@
357359 'wgMemCachedPersistent',
358360 'wgMemCachedServers',
359361 );
 362+
 363+ if ( $wgConfigureAllowDeferSetup ) {
 364+ // These settings are backward compatible settings which are used
 365+ // in Setup.php before the SetupAfterCache hook is called
 366+ $uneditable = array_merge( $uneditable, array(
 367+ # Uploads
 368+ 'wgUseSharedUploads',
 369+ 'wgUploadDirectory',
 370+ 'wgUploadBaseUrl',
 371+ 'wgUploadPath',
 372+ 'wgHashedUploadDirectory',
 373+ 'wgThumbnailScriptPath',
 374+ 'wgGenerateThumbnailOnParse',
 375+ 'wgSharedUploadDirectory',
 376+ 'wgSharedUploadPath',
 377+ 'wgHashedSharedUploadDirectory',
 378+ 'wgSharedThumbnailScriptPath',
 379+ 'wgSharedUploadDBname',
 380+ 'wgSharedUploadDBprefix',
 381+ 'wgCacheSharedUploads',
 382+ 'wgRepositoryBaseUrl',
 383+ 'wgFetchCommonsDescriptions',
 384+ # Recent changes
 385+ 'wgRCFilterByAge',
 386+ # Skins
 387+ 'wgSkipSkin',
 388+ # Cache
 389+ 'wgParserCacheType',
 390+ 'wgMessageCacheType',
 391+ ) );
 392+ }
 393+
 394+ return $uneditable;
360395 }
361396 }
Index: trunk/extensions/Configure/Configure.php
@@ -17,7 +17,7 @@
1818 'url' => 'http://www.mediawiki.org/wiki/Extension:Configure',
1919 'description' => 'Allow authorised users to configure the wiki via a web-based interface',
2020 'descriptionmsg' => 'configure-desc',
21 - 'version' => '0.13.8',
 21+ 'version' => '0.13.9',
2222 );
2323
2424 # Configuration part

Status & tagging log