r4917 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r4916‎ | r4917 | r4918 >
Date:05:27, 24 August 2004
Author:vibber
Status:old
Tags:
Comment:
Patch by Ivan Krstic, slightly modified, for the session handler wrong setting problem.

Bug 179: Detect when session.save_handler set incorrectly
http://bugzilla.wikipedia.org/show_bug.cgi?id=179
Modified paths:
  • /branches/REL1_3/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_3/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: branches/REL1_3/phase3/RELEASE-NOTES
@@ -10,6 +10,7 @@
1111 * When cookies are disabled, don't show login screen twice
1212 * Install should no longer die when PHP is pre-configured to compress output
1313 * Fixed bug that caused long Japanese pages to time out with Tidy active
 14+* When session.handler is set incorrectly, try automatic override to 'files'
1415
1516 == Version 1.3.1, 2004-08-14 ==
1617
Index: branches/REL1_3/phase3/includes/User.php
@@ -153,6 +153,10 @@
154154 global $wgSessionsInMemcached, $wgCookiePath, $wgCookieDomain;
155155 if( $wgSessionsInMemcached ) {
156156 require_once( 'MemcachedSessions.php' );
 157+ } elseif( 'files' != ini_get( 'session.save_handler' ) ) {
 158+ # If it's left on 'user' or another setting from another
 159+ # application, it will end up failing. Try to recover.
 160+ ini_set ( 'session.save_handler', 'files' );
157161 }
158162 session_set_cookie_params( 0, $wgCookiePath, $wgCookieDomain );
159163 session_cache_limiter( 'private, must-revalidate' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r4916Patch by Ivan Krstic, slightly modified, for the session handler wrong settin...vibber03:10, 24 August 2004

Status & tagging log