r49025 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49024‎ | r49025 | r49026 >
Date:01:56, 30 March 2009
Author:demon
Status:ok (Comments)
Tags:
Comment:
(bug 17947) On Special:SpecialPages, restricted special pages are now marked with <strong> tags, helps with text-based browsers
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSpecialpages.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSpecialpages.php
@@ -63,7 +63,7 @@
6464 $link = $sk->makeKnownLinkObj( $title , htmlspecialchars( $desc ) );
6565 if( $restricted ) {
6666 $includesRestrictedPages = true;
67 - $wgOut->addHTML( "<li class='mw-specialpages-page mw-specialpagerestricted'>{$link}</li>\n" );
 67+ $wgOut->addHTML( "<li class='mw-specialpages-page mw-specialpagerestricted'><strong>{$link}</strong></li>\n" );
6868 } else {
6969 $wgOut->addHTML( "<li>{$link}</li>\n" );
7070 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3841,7 +3841,7 @@
38423842 'specialpages-summary' => '', # do not translate or duplicate this message to other languages
38433843 'specialpages-note' => '----
38443844 * Normal special pages.
3845 -* <span class="mw-specialpagerestricted">Restricted special pages.</span>',
 3845+* <strong class="mw-specialpagerestricted">Restricted special pages.</strong>',
38463846 'specialpages-group-maintenance' => 'Maintenance reports',
38473847 'specialpages-group-other' => 'Other special pages',
38483848 'specialpages-group-login' => 'Login / sign up',
Index: trunk/phase3/RELEASE-NOTES
@@ -309,6 +309,8 @@
310310 * (bug 17617) HTML cleanup for ImagePage
311311 * (bug 17964) namespaceDupes.php no longer fails on an empty interwiki table
312312 * Improved error handling for image moving
 313+* (bug 17947) On Special:SpecialPages, restricted special pages are now marked
 314+ with <strong> tags, helps with text-based browsers
313315
314316 == API changes in 1.15 ==
315317 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Comments

#Comment by Simetrical (talk | contribs)   02:18, 30 March 2009

What bug did you really mean here?

#Comment by 😂 (talk | contribs)   02:32, 30 March 2009

Meant 17974, fixed in r49025

#Comment by Simetrical (talk | contribs)   13:14, 30 March 2009

You mean fixed in r49026. :P

#Comment by Umherirrender (talk | contribs)   15:52, 12 October 2009

This breaks easy css: .mw-specialpagerestricted { font-weight:normal; }. must changed to .mw-specialpagerestricted strong { font-weight:normal; }

I think, it is better when the class is at the strong and not at the li.

Status & tagging log