r49021 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r49020‎ | r49021 | r49022 >
Date:19:49, 29 March 2009
Author:vasilievvv
Status:ok
Tags:
Comment:
Fix a typo in the function name
Modified paths:
  • /trunk/phase3/includes/filerepo/FSRepo.php (modified) (history)
  • /trunk/phase3/includes/filerepo/LocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/LocalFile.php
@@ -1789,9 +1789,9 @@
17901790 $status = $repo->newGood();
17911791 $triplets = $this->getMoveTriplets();
17921792
1793 - $statusPreCheck = $this->checkFileExistance( 0 );
 1793+ $statusPreCheck = $this->checkFileExistence( 0 );
17941794 if( !$statusPreCheck->isOk() ) {
1795 - wfDebugLog( 'imagemove', "Move of {$this->file->name} aborted due to pre-move file existance check failure" );
 1795+ wfDebugLog( 'imagemove', "Move of {$this->file->name} aborted due to pre-move file existence check failure" );
17961796 return $statusPreCheck;
17971797 }
17981798 $statusDb = $this->doDBUpdates();
@@ -1802,7 +1802,7 @@
18031803 wfDebugLog( 'imagemove', "Error in moving files: " . $statusMove->getWikiText() );
18041804 $this->db->rollback();
18051805 } else {
1806 - $statusPostCheck = $this->checkFileExistance( 1 );
 1806+ $statusPostCheck = $this->checkFileExistence( 1 );
18071807 if( !$statusPostCheck->isOk() ) {
18081808 // This clearly mustn't have happend. FSRepo::storeBatch should have given out an error in that case.
18091809 wfDebugLog( 'imagemove', "ATTENTION! Move of {$this->file->name} has some files missing, while storeBatch() reported success" );
@@ -1870,11 +1870,11 @@
18711871 }
18721872
18731873 /*
1874 - * Checks file existance.
 1874+ * Checks file existence.
18751875 * Set $key = 0 for source files check
18761876 * and $key = 1 for destination files check.
18771877 */
1878 - function checkFileExistance( $key = 0 ) {
 1878+ function checkFileExistence( $key = 0 ) {
18791879 $files = array();
18801880 foreach( array_merge( array( $this->cur ), $this->olds ) as $file )
18811881 $files[$file[$key]] = $this->file->repo->getVirtualUrl() . '/public/' . rawurlencode( $file[$key] );
Index: trunk/phase3/includes/filerepo/FSRepo.php
@@ -213,12 +213,12 @@
214214 }
215215
216216 /**
217 - * Checks existance of specified array of files.
 217+ * Checks existence of specified array of files.
218218 *
219219 * @param array $files URLs of files to check
220220 * @param integer $flags Bitwise combination of the following flags:
221221 * self::FILES_ONLY Mark file as existing only if it is a file (not directory)
222 - * @return Either array of files and existance flags, or false
 222+ * @return Either array of files and existence flags, or false
223223 */
224224 function fileExistsBatch( $files, $flags = 0 ) {
225225 if ( !file_exists( $this->directory ) || !is_readable( $this->directory ) ) {

Status & tagging log