r48994 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48993‎ | r48994 | r48995 >
Date:12:03, 29 March 2009
Author:aaron
Status:ok
Tags:
Comment:
Prevent rating chart overflow
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/flaggedrevs.css (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/RatingHistory_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -257,7 +257,7 @@
258258 $wgAvailableRights[] = 'stablesettings';
259259
260260 # Bump this number every time you change flaggedrevs.css/flaggedrevs.js
261 -$wgFlaggedRevStyleVersion = 56;
 261+$wgFlaggedRevStyleVersion = 57;
262262
263263 $wgExtensionFunctions[] = 'efLoadFlaggedRevs';
264264
Index: trunk/extensions/FlaggedRevs/flaggedrevs.css
@@ -341,25 +341,25 @@
342342 }
343343
344344 /* Reader feedback form */
345 -.fr_reader_feedback_graph {
346 - width: 100%;
347 - overflow: auto;
348 -}
349 -
350345 .fr_reader_feedback_plot {
351346 background-color: #F8F8F8;
352347 }
353348
 349+.fr_reader_feedback_graph,
 350+.fr_reader_feedback_ratings,
354351 .fr_reader_feedback_users {
 352+ width: 100%;
 353+ overflow: auto;
 354+}
 355+
 356+.fr_reader_feedback_users {
355357 background-color: #F0F0F0;
356 - width: 100%;
357358 max-height:410px;
358 - overflow: auto;
359359 font-size: 90%;
360360 }
361361
362362 .fr_reader_feedback_table {
363 - margin: 1em 1em 1em 0;
 363+ margin: .5em .5em .5em .5em;
364364 background: #f9f9f9;
365365 border: 1px #AAA solid;
366366 border-collapse: collapse;
Index: trunk/extensions/FlaggedRevs/specialpages/RatingHistory_body.php
@@ -76,13 +76,15 @@
7777 $this->doPurge ? 'skipCache' : 'useCache'
7878 );
7979 if( $html ) {
80 - $wgOut->addHTML( '<h2>'.wfMsgHtml('ratinghistory-table')."</h2>\n".$html );
 80+ $wgOut->addHTML( '<h2>'.wfMsgHtml('ratinghistory-table')."</h2>\n".
 81+ "<div class='fr_reader_feedback_ratings'>$html</div>" );
8182 }
8283 }
8384
8485 protected function showForm() {
8586 global $wgOut, $wgScript;
86 - $form = Xml::openElement( 'form', array( 'name' => 'reviewedpages', 'action' => $wgScript, 'method' => 'get' ) );
 87+ $form = Xml::openElement( 'form', array( 'name' => 'reviewedpages',
 88+ 'action' => $wgScript, 'method' => 'get' ) );
8789 $form .= "<fieldset>";
8890 $form .= "<legend>".wfMsgExt( 'ratinghistory-leg',array('parseinline'),
8991 $this->page->getPrefixedText() )."</legend>\n";

Status & tagging log