r48959 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48958‎ | r48959 | r48960 >
Date:13:05, 28 March 2009
Author:daniel
Status:deferred
Tags:
Comment:
don't force source index when resolving redirects after all. looks good in explain, but performs worsin in an update
Modified paths:
  • /trunk/WikiWord/WikiWordBuilder/src/main/java/de/brightbyte/wikiword/store/builder/DatabaseLocalConceptStoreBuilder.java (modified) (history)

Diff [purge]

Index: trunk/WikiWord/WikiWordBuilder/src/main/java/de/brightbyte/wikiword/store/builder/DatabaseLocalConceptStoreBuilder.java
@@ -748,7 +748,7 @@
749749 if (beginTask("finishAliases", "resolveRedirects:link")) {
750750 //XXX: SLOW!
751751 //TODO: smaller chunks? chunk on target table, not alias table? force index?
752 - int n = resolveRedirects(aliasTable, linkTable, "target_name", "target", AliasScope.REDIRECT, 8, null, "source");
 752+ int n = resolveRedirects(aliasTable, linkTable, "target_name", "target", AliasScope.REDIRECT, 8, null, null);
753753 endTask("finishAliases", "resolveRedirects:link", n+" entries");
754754 }
755755

Status & tagging log