r48834 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48833‎ | r48834 | r48835 >
Date:15:55, 25 March 2009
Author:aaron
Status:ok
Tags:
Comment:
Avoid aliasing on index field
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php
@@ -348,6 +348,7 @@
349349 $conds['cl_to'] = $this->category;
350350 $useIndex['categorylinks'] = 'cl_from';
351351 }
 352+ $this->mIndexField = 'fp_pending_since';
352353 # Show outdated version for a specific review level
353354 } else {
354355 $tables[] = 'flaggedpage_pending';
@@ -374,7 +375,9 @@
375376 $conds['cl_to'] = $this->category;
376377 $useIndex['categorylinks'] = 'cl_from';
377378 }
 379+ $this->mIndexField = 'fpp_pending_since';
378380 }
 381+ $fields[] = $this->mIndexField; // Pager needs this
379382 # Filter namespace
380383 if( $this->namespace !== NULL ) {
381384 $conds['page_namespace'] = $this->namespace;
@@ -399,7 +402,7 @@
400403 }
401404
402405 function getIndexField() {
403 - return 'pending_since';
 406+ return $this->mIndexField;
404407 }
405408
406409 function getStartBody() {

Status & tagging log