r48827 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48826‎ | r48827 | r48828 >
Date:14:48, 25 March 2009
Author:aaron
Status:ok
Tags:
Comment:
Double check 'hideuser' before blocking
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -395,7 +395,8 @@
396396 }
397397
398398 if( $this->BlockHideName ) {
399 - if( !$userId ) {
 399+ // Recheck params here...
 400+ if( !$userId || !$wgUser->isAllowed('hideuser') ) {
400401 // IP users should not be hidden
401402 $this->BlockHideName = false;
402403 } else if( $expiry !== 'infinity' ) {

Status & tagging log