r48825 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48824‎ | r48825 | r48826 >
Date:14:42, 25 March 2009
Author:werdna
Status:ok
Tags:
Comment:
Fail silently for trying to add invalid titles to books
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -355,6 +355,7 @@
356356
357357 static function addArticleFromName( $namespace, $name, $oldid=0 ) {
358358 $title = Title::makeTitleSafe( $namespace, $name );
 359+ if (!$title) return false;
359360 return self::addArticle( $title, $oldid );
360361 }
361362

Status & tagging log