r48805 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48804‎ | r48805 | r48806 >
Date:11:35, 25 March 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r47755 "(bug 16899) DISPLAYTITLE should allow Arabic and Persian harakats"
This doesn't seem to allow things in DISPLAYTITLE, but rather forbid things in regular titles. Reasoning behind it is unclear.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -255,7 +255,6 @@
256256 * (bug 17460) Client ecoding is now correctly set for PostgreSQL
257257 * (bug 17648) Prevent floats from intruding into edit area in previews if no
258258 toolbar present
259 -* (bug 16899) DISPLAYTITLE should allow Arabic and Persian harakats
260259 * (bug 17692) Added (list of members) link to 'user' in Special:Listgrouprights
261260 * (bug 17707) Show file destination as plain text if &wpForReUpload=1
262261 * (bug 10172) Moved setting of "changed since last visit" flags out of the job
Index: trunk/phase3/includes/Title.php
@@ -2197,9 +2197,6 @@
21982198 #
21992199 $dbkey = preg_replace( '/[ _]+/', '_', $dbkey );
22002200 $dbkey = trim( $dbkey, '_' );
2201 -
2202 - # Clean up Arabic harakats (bug 16899)
2203 - $dbkey = preg_replace( '/[\x{064B}-\x{0652}]/Su', '', $dbkey );
22042201
22052202 if ( '' == $dbkey ) {
22062203 return false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47755(bug 16899) DISPLAYTITLE should allow Arabic and Persian harakatshuji18:41, 24 February 2009

Status & tagging log