r48801 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48800‎ | r48801 | r48802 >
Date:10:11, 25 March 2009
Author:raymond
Status:ok
Tags:
Comment:
Add a class if 'missingsummary' is triggered to allow styling of the summary line
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -149,7 +149,9 @@
150150 * Added $wgUserrightsInterwikiDelimiter to allow changing the delimiter
151151 used in Special:UserRights to denote the user should be searched for
152152 on a different database
153 -
 153+* Add a class if 'missingsummary' is triggered to allow styling of the summary
 154+ line
 155+
154156 === Bug fixes in 1.15 ===
155157 * (bug 16968) Special:Upload no longer throws useless warnings.
156158 * (bug 17000) Special:RevisionDelete now checks if the database is locked
Index: trunk/phase3/includes/EditPage.php
@@ -1363,10 +1363,14 @@
13641364 if ( $this->section == 'new' ) {
13651365 $commentsubject = '';
13661366 if ( !$wgRequest->getBool( 'nosummary' ) ) {
 1367+ # Add a class if 'missingsummary' is triggered to allow styling of the summary line
 1368+ $summaryClass = $this->missingSummary ? 'mw-summarymissed' : 'mw-summary';
 1369+
13671370 $commentsubject =
13681371 Xml::tags( 'label', array( 'for' => 'wpSummary' ), $subject );
13691372 $commentsubject =
1370 - Xml::tags( 'span', array( 'id' => 'wpSummaryLabel' ), $commentsubject );
 1373+ Xml::tags( 'span', array( 'class' => $summaryClass, 'id' => "wpSummaryLabel" ),
 1374+ $commentsubject );
13711375 $commentsubject .= ' ';
13721376 $commentsubject .= Xml::input( 'wpSummary',
13731377 60,
@@ -1385,10 +1389,13 @@
13861390 } else {
13871391 $commentsubject = '';
13881392
 1393+ # Add a class if 'missingsummary' is triggered to allow styling of the summary line
 1394+ $summaryClass = $this->missingSummary ? 'mw-summarymissed' : 'mw-summary';
 1395+
13891396 $editsummary = Xml::tags( 'label', array( 'for' => 'wpSummary' ), $summary );
1390 - $editsummary =
1391 - Xml::tags( 'span', array( 'id' => 'wpSummaryLabel' ), $editsummary ) . ' ';
1392 -
 1397+ $editsummary = Xml::tags( 'span', array( 'class' => $summaryClass, 'id' => "wpSummaryLabel" ),
 1398+ $editsummary ) . ' ';
 1399+
13931400 $editsummary .= Xml::input( 'wpSummary',
13941401 60,
13951402 $summarytext,
@@ -1397,11 +1404,11 @@
13981405 'maxlength' => '200',
13991406 'tabindex' => '1'
14001407 ) );
1401 -
 1408+
14021409 // No idea where this is closed.
14031410 $editsummary = Xml::openElement( 'div', array( 'class' => 'editOptions' ) )
14041411 . $editsummary . '<br/>';
1405 -
 1412+
14061413 $summarypreview = '';
14071414 if ( $summarytext && $this->preview ) {
14081415 $summarypreview =

Status & tagging log