r48792 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48791‎ | r48792 | r48793 >
Date:08:09, 25 March 2009
Author:raymond
Status:ok
Tags:
Comment:
Fix per comment in r48720: Remove style from code and use same table stylings as other tables.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialTags.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -253,10 +253,12 @@
254254 /*
255255 * Special:ListGroupRights styling
256256 * Special:Statistics styling
 257+ * Special:Tags styling
257258 */
258259
259260 table.mw-listgrouprights-table,
260 -table.mw-statistics-table {
 261+table.mw-statistics-table,
 262+table.mw-tags-table {
261263 border: 1px solid #ccc;
262264 border-collapse: collapse;
263265 }
@@ -266,7 +268,8 @@
267269 }
268270
269271 table.mw-listgrouprights-table td, table.mw-listgrouprights-table th,
270 -table.mw-statistics-table td, table.mw-statistics-table th {
 272+table.mw-statistics-table td, table.mw-statistics-table th,
 273+table.mw-tags-table td, table.mw-tags-table th {
271274 padding: 0.5em 0.2em 0.5em 0.2em;
272275 border: 1px solid #ccc;
273276 }
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1469,7 +1469,7 @@
14701470 * to ensure that client-side caches don't keep obsolete copies of global
14711471 * styles.
14721472 */
1473 -$wgStyleVersion = '206';
 1473+$wgStyleVersion = '207';
14741474
14751475
14761476 # Server-side caching:
Index: trunk/phase3/includes/specials/SpecialTags.php
@@ -36,7 +36,7 @@
3737 $html .= $this->doTagRow( $tag, 0 );
3838 }
3939
40 - $wgOut->addHTML( Xml::tags( 'table', array( 'style' => 'width: 80%', 'class' => 'mw-tags-table' ), $html ) );
 40+ $wgOut->addHTML( Xml::tags( 'table', array( 'class' => 'mw-tags-table' ), $html ) );
4141 }
4242
4343 function doTagRow( $tag, $hitcount ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r48720Add a class to the table and use a nice Xml::function...raymond21:20, 23 March 2009

Status & tagging log