r48685 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48684‎ | r48685 | r48686 >
Date:16:36, 22 March 2009
Author:ashley
Status:ok
Tags:
Comment:
prefix two input IDs on Special:Log with 'mw-log-' to avoid too generic IDs
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -170,7 +170,7 @@
171171 * @return String: Formatted HTML
172172 */
173173 private function getUserInput( $user ) {
174 - return Xml::inputLabel( wfMsg( 'specialloguserlabel' ), 'user', 'user', 15, $user );
 174+ return Xml::inputLabel( wfMsg( 'specialloguserlabel' ), 'user', 'mw-log-user', 15, $user );
175175 }
176176
177177 /**
@@ -178,7 +178,7 @@
179179 * @return String: Formatted HTML
180180 */
181181 private function getTitleInput( $title ) {
182 - return Xml::inputLabel( wfMsg( 'speciallogtitlelabel' ), 'page', 'page', 20, $title );
 182+ return Xml::inputLabel( wfMsg( 'speciallogtitlelabel' ), 'page', 'mw-log-page', 20, $title );
183183 }
184184
185185 /**
Index: trunk/phase3/RELEASE-NOTES
@@ -145,6 +145,8 @@
146146 enabled. Image width and height are now recognized, and when using ImageMagick,
147147 optional flattening to PNG or JPEG for inline display can be enabled by setting
148148 $wgTiffThumbnailType
 149+* Renamed two input IDs on Special:Log from 'page' and 'user' to 'mw-log-page' and
 150+ 'mw-log-user', respectively
149151
150152 === Bug fixes in 1.15 ===
151153 * (bug 16968) Special:Upload no longer throws useless warnings.

Status & tagging log