r48646 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48645‎ | r48646 | r48647 >
Date:20:45, 20 March 2009
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Backported r48644
Modified paths:
  • /branches/REL1_14/phase3/includes/filerepo/ArchivedFile.php (modified) (history)

Diff [purge]

Index: branches/REL1_14/phase3/includes/filerepo/ArchivedFile.php
@@ -74,14 +74,16 @@
7575 }
7676 $conds = array();
7777
78 - if ($this->id>0)
 78+ if( $this->id > 0 )
7979 $conds['fa_id'] = $this->id;
80 - if ($this->key)
81 - $conds['fa_storage_key'] = $this->key;
82 - if ($this->title)
 80+ if( $this->key ) {
 81+ $conds['fa_storage_group'] = $this->group;
 82+ $conds['fa_storage_key'] = $this->key;
 83+ }
 84+ if( $this->title )
8385 $conds['fa_name'] = $this->title->getDBkey();
8486
85 - if (!count($conds))
 87+ if( !count($conds))
8688 throw new MWException( "No specific information for retrieving archived file" );
8789
8890 if( !$this->title || $this->title->getNamespace() == NS_FILE ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r53178* Updates for release of 1.14.0...tstarling16:25, 13 July 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r48644Add missing group cond to queryaaron20:39, 20 March 2009

Comments

#Comment by Tim Starling (talk | contribs)   16:12, 13 July 2009

Missing release notes. The formatting changes need to be reverted, they are not appropriate for backport.

Status & tagging log