r48559 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48558‎ | r48559 | r48560 >
Date:00:50, 19 March 2009
Author:kim
Status:deferred
Tags:
Comment:
revisions now also supported everywhere
Modified paths:
  • /trunk/wikiation/installer/download_installer.py (modified) (history)
  • /trunk/wikiation/installer/extension_installer.py (modified) (history)
  • /trunk/wikiation/installer/installation_system.py (modified) (history)

Diff [purge]

Index: trunk/wikiation/installer/extension_installer.py
@@ -57,7 +57,7 @@
5858 env={}
5959
6060 env=dict(env)
61 - env["EXTENSIONS_SVN"]=settings.extensionsdir
 61+ env["EXTENSIONS_SVN"]=self.get_extensionsdir()
6262 env["DATABASE_NAME"]=dbname(self.instance)
6363 env["IN_INSTANCE"]=self.instance
6464
Index: trunk/wikiation/installer/installation_system.py
@@ -331,3 +331,12 @@
332332 if self.can_exec(installer_name,"uninstall"):
333333 self.exec_task(installer_name,"uninstall")
334334
 335+ def get_extensionsdir(self):
 336+ """return the relevant extensionsdir to look in"""
 337+ extensionsdir=None
 338+ if self.tag:
 339+ extensionsdir=settings.tagsdir+"/"+self.tag+"/"+settings.extensionssubdir
 340+ else:
 341+ extensionsdir=settings.extensionsdir
 342+
 343+ return extensionsdir
Index: trunk/wikiation/installer/download_installer.py
@@ -58,8 +58,13 @@
5959
6060 def do_download (self, installer_name, destination_dir):
6161 os.chdir(destination_dir)
62 - command="svn checkout '"+\
63 - settings.extensionsdir+"/"+\
 62+
 63+ r=''
 64+ if self.revision:
 65+ r="-r "+str(self.revision)
 66+ command="svn checkout "+\
 67+ r+" '"+\
 68+ self.get_extensionsdir()+"/"+\
6469 installer_name+"'"
6570 #print command
6671 result=os.system(command)

Status & tagging log