r48490 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48489‎ | r48490 | r48491 >
Date:15:40, 17 March 2009
Author:raymond
Status:ok
Tags:
Comment:
Follow up r48456: Document the new right in DefaultSettings.
* Document the hard coded limit of 5
* Add a right-... message for the new right
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1038,6 +1038,7 @@
10391039 'right-userrights-interwiki',
10401040 'right-siteadmin',
10411041 'right-reset-passwords',
 1042+ 'right-override-export-depth',
10421043 ),
10431044 'rightslog' => array(
10441045 'rightslog',
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1259,6 +1259,8 @@
12601260 # $wgGroupPermissions['bureaucrat']['reset-passwords'] = true;
12611261 // Permission to change users' groups assignments across wikis
12621262 #$wgGroupPermissions['bureaucrat']['userrights-interwiki'] = true;
 1263+// Permission to export pages including linked pages regardless of $wgExportMaxLinkDepth
 1264+#$wgGroupPermissions['bureaucrat']['override-export-depth'] = true;
12631265
12641266 #$wgGroupPermissions['sysop']['deleterevision'] = true;
12651267 // To hide usernames from users and Sysops
@@ -2298,10 +2300,13 @@
22992301 * pages linked to from the pages you specify. Since this number
23002302 * can become *insanely large* and could easily break your wiki,
23012303 * it's disabled by default for now.
 2304+ *
 2305+ * There's a HARD CODED limit of 5 levels of recursion to prevent a
 2306+ * crazy-big export from being done by someone setting the depth
 2307+ * number too high. In other words, last resort safety net.
23022308 */
23032309 $wgExportMaxLinkDepth = 0;
23042310
2305 -
23062311 /**
23072312 * Edits matching these regular expressions in body text
23082313 * will be recognised as spam and rejected automatically.
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1721,6 +1721,7 @@
17221722 'right-userrights-interwiki' => 'Edit user rights of users on other wikis',
17231723 'right-siteadmin' => 'Lock and unlock the database',
17241724 'right-reset-passwords' => "Reset other users' passwords",
 1725+'right-override-export-depth' => 'Export pages including linked pages up to a depth of 5',
17251726
17261727 # User rights log
17271728 'rightslog' => 'User rights log',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r48456Added override of $wgExportMaxLinkDepth via the 'override-export-depth' right...tparscal20:40, 16 March 2009

Status & tagging log