r48483 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48482‎ | r48483 | r48484 >
Date:09:18, 17 March 2009
Author:aaron
Status:ok
Tags:
Comment:
add queue comment
Modified paths:
  • /trunk/extensions/Renameuser/SpecialRenameuser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Renameuser/SpecialRenameuser_body.php
@@ -455,6 +455,12 @@
456456 );
457457 }
458458 // Construct jobqueue updates...
 459+ // FIXME: if a bureaucrat renames a user in error, he/she
 460+ // must be careful to wait until the rename finishes before
 461+ // renaming back. This is due to the fact the the job "queue"
 462+ // is not really FIFO, so we might end up with a bunch of edits
 463+ // randomly mixed between the two new names. Some sort of rename
 464+ // lock might be in order...
459465 foreach( $this->tablesJob as $table => $params ) {
460466 $userTextC = $params[0]; // some *_user_text column
461467 $userIDC = $params[1]; // some *_user column

Status & tagging log