r48411 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48410‎ | r48411 | r48412 >
Date:19:52, 14 March 2009
Author:ialex
Status:ok
Tags:
Comment:
(bug 17972) Special:FileDuplicateSearch form now works correctly on wikis that don't use PathInfo or short urls
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialFileDuplicateSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialFileDuplicateSearch.php
@@ -64,7 +64,7 @@
6565 * Output the HTML search form, and constructs the FileDuplicateSearch object.
6666 */
6767 function wfSpecialFileDuplicateSearch( $par = null ) {
68 - global $wgRequest, $wgTitle, $wgOut, $wgLang, $wgContLang;
 68+ global $wgRequest, $wgOut, $wgLang, $wgContLang, $wgScript;
6969
7070 $hash = '';
7171 $filename = isset( $par ) ? $par : $wgRequest->getText( 'filename' );
@@ -85,7 +85,8 @@
8686
8787 # Create the input form
8888 $wgOut->addHTML(
89 - Xml::openElement( 'form', array( 'id' => 'fileduplicatesearch', 'method' => 'get', 'action' => $wgTitle->getLocalUrl() ) ) .
 89+ Xml::openElement( 'form', array( 'id' => 'fileduplicatesearch', 'method' => 'get', 'action' => $wgScript ) ) .
 90+ Xml::hidden( 'title', SpecialPage::getTitleFor( 'FileDuplicateSearch' )->getPrefixedDbKey() ) .
9091 Xml::openElement( 'fieldset' ) .
9192 Xml::element( 'legend', null, wfMsg( 'fileduplicatesearch-legend' ) ) .
9293 Xml::inputLabel( wfMsg( 'fileduplicatesearch-filename' ), 'filename', 'filename', 50, $filename ) . ' ' .
Index: trunk/phase3/RELEASE-NOTES
@@ -265,6 +265,8 @@
266266 * Special:Export doesn't use raw SQL queries anymore
267267 * (bug 14771) Thumbnail links to individual DjVu pages have two no longer have
268268 two "page" parameters
 269+* (bug 17972) Special:FileDuplicateSearch form now works correctly on wikis that
 270+ don't use PathInfo or short urls
269271
270272
271273 == API changes in 1.15 ==

Status & tagging log