r48167 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48166‎ | r48167 | r48168 >
Date:17:23, 8 March 2009
Author:siebrand
Status:deferred
Tags:
Comment:
* allow PLURAL for $4 and $5 in 'review_statistic_cell'
* reworded 'review_statistic_cell'
Modified paths:
  • /trunk/extensions/Review/Review.i18n.php (modified) (history)
  • /trunk/extensions/Review/Review.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Review/Review.i18n.php
@@ -30,7 +30,7 @@
3131 'review_total_statistics' => "Total",
3232 'review_statistics_left_corner' => "Revision",
3333 'review_version_link' => "Revision #$1",
34 - 'review_statistic_cell' => "Average: $1 of $2<br />($4 users, $5 anons)",
 34+ 'review_statistic_cell' => "Average: $1 of $2<br />($4 registered {{PLURAL:$4|user|users}}, $5 anonymous {{PLURAL:$5|user|users}})",
3535 'review_version_statistic_cell' => "$1 of $2",
3636 'review_version_reviews_link' => "<small>(version reviews)</small>",
3737 'review_concerns_page' => "This review is about the page \"$1\".",
Index: trunk/extensions/Review/Review.php
@@ -626,13 +626,14 @@
627627 ) ;
628628 $ret .= "<br />" . htmlentities ( $data[$type]->comment ) ;
629629 } else {
630 - $ret .= wfMsgForContent ( 'review_statistic_cell' ,
631 - sprintf ( "%1.1f" , $average ) ,
632 - $data[$type]->max ,
633 - $data[$type]->total_count ,
634 - $data[$type]->total_count - $data[$type]->anon_count ,
635 - $data[$type]->anon_count
636 - ) ;
 630+ $ret .= wfMsgExt( 'review_statistic_cell' ,
 631+ array( 'content', 'parsemag' ),
 632+ sprintf ( "%1.1f" , $average ) ,
 633+ $data[$type]->max ,
 634+ $data[$type]->total_count ,
 635+ $data[$type]->total_count - $data[$type]->anon_count ,
 636+ $data[$type]->anon_count
 637+ );
637638 }
638639 $ret .= "</div>" ;
639640 } else {

Status & tagging log