r48059 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48058‎ | r48059 | r48060 >
Date:13:38, 5 March 2009
Author:demon
Status:ok
Tags:
Comment:
(bug 17799) Special:Random no longer throws a database error when a non-namespace is given, now silently falls back to NS_MAIN
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRandompage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRandompage.php
@@ -23,7 +23,7 @@
2424 }
2525
2626 public function setNamespace ( $ns ) {
27 - if( $ns < NS_MAIN ) $ns = NS_MAIN;
 27+ if( !$ns || $ns < NS_MAIN ) $ns = NS_MAIN;
2828 $this->namespaces = array( $ns );
2929 }
3030
Index: trunk/phase3/RELEASE-NOTES
@@ -239,6 +239,8 @@
240240 * (bug 17761) "show/hide" link in page history in now works for the first
241241 displayed revision if it's not the current one
242242 * (bug 17722) Fix regression where users are unable to change temporary passwords
 243+* (bug 17799) Special:Random no longer throws a database error when a non-
 244+ namespace is given, silently falls back to NS_MAIN
243245
244246 == API changes in 1.15 ==
245247 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Status & tagging log