r48056 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48055‎ | r48056 | r48057 >
Date:08:59, 5 March 2009
Author:ialex
Status:ok
Tags:
Comment:
Allow entities in "revreview-accuracy" and similar messages
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -1310,7 +1310,7 @@
13111311 }
13121312 $quantity = count( $label );
13131313 $form .= Xml::openElement( 'span', array('class' => 'fr-rating-options') ) . "\n";
1314 - $form .= "<b>" . Xml::label( FlaggedRevs::getTagMsg($quality), "wp$quality" ) . ":</b>\n";
 1314+ $form .= "<b>" . Xml::tags( 'label', array( 'for' => "wp$quality" ), FlaggedRevs::getTagMsg( $quality ) ) . ":</b>\n";
13151315 # If the sum of qualities of all flags is above 6, use drop down boxes
13161316 # 6 is an arbitrary value choosen according to screen space and usability
13171317 if( $size > 6 ) {
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -209,7 +209,7 @@
210210 public static function getTagMsg( $tag ) {
211211 self::load();
212212 wfLoadExtensionMessages( 'FlaggedRevs' );
213 - return wfMsgHtml("revreview-$tag");
 213+ return wfMsgExt( "revreview-$tag", array( 'escapenoentities' ) );
214214 }
215215
216216 /**

Status & tagging log