r48049 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48048‎ | r48049 | r48050 >
Date:06:00, 5 March 2009
Author:aaron
Status:ok
Tags:
Comment:
(bug 17792) Hide DELETED_USER items
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -384,6 +384,8 @@
385385 list( $tables, $index, $userCond, $join_cond ) = $this->getUserCond();
386386
387387 $conds = array_merge( $userCond, $this->getNamespaceCond() );
 388+ // Paranoia: avoid brute force searches (bug 17792)
 389+ $conds[] = 'rev_deleted & ' . Revision::DELETED_USER . ' = 0';
388390 $join_cond['page'] = array( 'INNER JOIN', 'page_id=rev_page' );
389391
390392 $queryInfo = array(
@@ -398,7 +400,8 @@
399401 'join_conds' => $join_cond
400402 );
401403
402 - ChangeTags::modifyDisplayQuery( $queryInfo['tables'], $queryInfo['fields'], $queryInfo['conds'], $queryInfo['join_conds'], $this->tagFilter );
 404+ ChangeTags::modifyDisplayQuery( $queryInfo['tables'], $queryInfo['fields'], $queryInfo['conds'],
 405+ $queryInfo['join_conds'], $this->tagFilter );
403406
404407 wfRunHooks( 'ContribsPager::getQueryInfo', array( &$this, &$queryInfo ) );
405408 return $queryInfo;

Follow-up revisions

RevisionCommit summaryAuthorDate
r48622Visibility tweak on ar_deleted per bug 17792aaron04:13, 20 March 2009

Status & tagging log