r47904 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r47903‎ | r47904 | r47905 >
Date:11:02, 1 March 2009
Author:catrope
Status:ok
Tags:
Comment:
Fix up r47901: don't return the string "true" or "false", be consistent with the rest of the API
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryLogEvents.php
——@@ -162,8 +162,8 @@
163163 $vals[$type] = $vals2;
164164 }
165165 }
166 - if (isset ($params[1])) {
167 - $vals[$type]['suppressedredirect'] = (bool) $params[1];
 166+ if (isset ($params[1]) && $params[1]) {
 167+ $vals[$type]['suppressedredirect'] = '';
168168 }
169169 $params = null;
170170 break;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47901For move logs, log_params can have a "suppressedRedirect" boolean, as a secon...nicdumz05:13, 1 March 2009

Status & tagging log