r47891 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47890‎ | r47891 | r47892 >
Date:14:57, 28 February 2009
Author:maikmerten
Status:ok
Tags:
Comment:
don't convert null to a String value of "null" for userId and password - a username and password of "null" obviously confuses Amazon's S3. Thanks to Chris Double for catching this one.
Modified paths:
  • /trunk/cortado/src/com/fluendo/plugin/HTTPSrc.java (modified) (history)

Diff [purge]

Index: trunk/cortado/src/com/fluendo/plugin/HTTPSrc.java
@@ -405,13 +405,13 @@
406406 documentBase = (URL)value;
407407 }
408408 else if (name.equals("userId")) {
409 - userId = String.valueOf(value);
 409+ userId = (value == null) ? null : String.valueOf(value);
410410 }
411411 else if (name.equals("userAgent")) {
412412 userAgent = String.valueOf(value);
413413 }
414414 else if (name.equals("password")) {
415 - password = String.valueOf(value);
 415+ password = (value == null) ? null : String.valueOf(value);
416416 }
417417 else if (name.equals("readSize")) {
418418 readSize = Integer.parseInt((String)value);

Status & tagging log