r47866 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47865‎ | r47866 | r47867 >
Date:16:39, 27 February 2009
Author:ashley
Status:deferred
Tags:
Comment:
SocialProfile: cleanup & spacing
Modified paths:
  • /trunk/extensions/SocialProfile/UserRelationship/SpecialViewRelationships.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserRelationship/SpecialViewRelationships.php
@@ -46,7 +46,7 @@
4747 * It will automatically return them to the ViewRelationships page
4848 */
4949 if( $wgUser->getID() == 0 && $user_name == '' ){
50 - $wgOut->setPagetitle( wfMsg('ur-error-page-title') );
 50+ $wgOut->setPageTitle( wfMsg('ur-error-page-title') );
5151 $login = SpecialPage::getTitleFor( 'UserLogin' );
5252 $wgOut->redirect( $login->escapeFullURL('returnto=Special:ViewRelationships') );
5353 return false;
@@ -71,7 +71,7 @@
7272 * Error message for username that does not exist (from URL)
7373 */
7474 if( $user_id == 0 ){
75 - $wgOut->setPagetitle( wfMsg('ur-error-title') );
 75+ $wgOut->setPageTitle( wfMsg('ur-error-title') );
7676 $out .= '<div class="relationship-error-message">
7777 '.wfMsg('ur-error-message-no-user').'
7878 </div>
@@ -101,9 +101,9 @@
102102 #$invite_contacts_link = SpecialPage::getTitleFor( 'InviteContacts' );
103103
104104 if( $rel_type == 1 ) {
105 - $output .= $wgOut->setPagetitle( wfMsg( 'ur-title-friend', $rel->user_name ) );
 105+ $output .= $wgOut->setPageTitle( wfMsg( 'ur-title-friend', $rel->user_name ) );
106106 $total = $friend_count;
107 - $rem = wfMsg('ur-remove-relationship-friend');
 107+ $rem = wfMsg( 'ur-remove-relationship-friend' );
108108 $output .= '<div class="back-links">
109109 <a href="'.$back_link->escapeFullURL().'">'.wfMsg( 'ur-backlink', $rel->user_name ).'</a>
110110 </div>
@@ -111,9 +111,9 @@
112112 wfMsgExt( 'ur-relationship-count-friends', 'parsemag', $rel->user_name, $total, $invite_contacts_link->escapeFullURL() ).
113113 '</div>';
114114 } else {
115 - $output .= $wgOut->setPagetitle( wfMsg( 'ur-title-foe', $rel->user_name ) );
 115+ $output .= $wgOut->setPageTitle( wfMsg( 'ur-title-foe', $rel->user_name ) );
116116 $total = $foe_count;
117 - $rem = wfMsg('ur-remove-relationship-foe');
 117+ $rem = wfMsg( 'ur-remove-relationship-foe' );
118118 $output .= '<div class="back-links">
119119 <a href="'.$back_link->escapeFullURL().'">'.wfMsg( 'ur-backlink', $rel->user_name ).'</a>
120120 </div>
@@ -160,15 +160,15 @@
161161 <div class=\"relationship-actions\">";
162162 if( $indivRelationship == false ) {
163163 $output .= $wgLang->pipeList( array(
164 - "<a href=\"" . $add_relationship_link->escapeFullURL( 'user=' . $user_safe . '&rel_type=1') . "\">" . wfMsg( 'ur-add-friend') . "</a>",
165 - "<a href=\"" . $add_relationship_link->escapeFullURL( 'user=' . $user_safe . '&rel_type=2') . "\">" . wfMsg( 'ur-add-foe' ) . "</a>",
 164+ '<a href="' . $add_relationship_link->escapeFullURL( 'user=' . $user_safe . '&rel_type=1' ) . '">' . wfMsg( 'ur-add-friend' ) . '</a>&nbsp;',
 165+ '&nbsp;<a href="' . $add_relationship_link->escapeFullURL( 'user=' . $user_safe . '&rel_type=2' ) . '">' . wfMsg( 'ur-add-foe' ) . '</a>&nbsp;',
166166 ''
167167 ) );
168168 } else if( $user_name == $wgUser->getName() ) {
169 - $output .= "<a href=\"".$remove_relationship_link->escapeFullURL('user='.$user_safe)."\">".$rem."</a>";
170 - $output .= wfMsgExt( 'pipe-separator' , 'escapenoentities' );
 169+ $output .= '<a href="'.$remove_relationship_link->escapeFullURL( 'user=' . $user_safe ) . '">' . $rem . '</a>&nbsp;';
 170+ $output .= wfMsgExt( 'pipe-separator', 'escapenoentities' );
171171 }
172 - $output .= "<a href=\"".$give_gift_link->escapeFullURL('user='.$user_safe)."\">".wfMsg('ur-give-gift')."</a>";
 172+ $output .= '&nbsp;<a href="'.$give_gift_link->escapeFullURL( 'user=' . $user_safe ).'">'.wfMsg( 'ur-give-gift' ).'</a>';
173173
174174 $output .= '</div>
175175 <div class="cleared"></div>

Status & tagging log