r47838 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47837‎ | r47838 | r47839 >
Date:20:10, 26 February 2009
Author:demon
Status:ok
Tags:
Comment:
Fix regression from r30602. 'noindex,nofollow' was being applied when local page text didn't exist for foreign images. Moved it to where it should be used, with 'noimage'
Modified paths:
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -105,7 +105,6 @@
106106 } else {
107107 # Just need to set the right headers
108108 $wgOut->setArticleFlag( true );
109 - $wgOut->setRobotPolicy( 'noindex,nofollow' );
110109 $wgOut->setPageTitle( $this->mTitle->getPrefixedText() );
111110 $this->viewUpdates();
112111 }
@@ -469,6 +468,7 @@
470469 $title = SpecialPage::getTitleFor( 'Upload' );
471470 $link = $sk->makeKnownLinkObj($title, wfMsgHtml('noimage-linktext'),
472471 'wpDestFile=' . urlencode( $this->displayImg->getName() ) );
 472+ $wgOut->setRobotPolicy( 'noindex,nofollow' );
473473 $wgOut->addHTML( wfMsgWikiHtml( 'noimage', $link ) );
474474 }
475475 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r30602Make the default robot policy a configurable option....vyznev00:55, 6 February 2008

Status & tagging log