r47827 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47826‎ | r47827 | r47828 >
Date:10:11, 26 February 2009
Author:catrope
Status:ok
Tags:
Comment:
API: (bug 17673) Using &exportnowrap without &export results in an internal error
Modified paths:
  • /trunk/phase3/includes/api/ApiQuery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQuery.php
@@ -173,7 +173,8 @@
174174
175175 public function getCustomPrinter() {
176176 // If &exportnowrap is set, use the raw formatter
177 - if ($this->getParameter('exportnowrap'))
 177+ if ($this->getParameter('export') &&
 178+ $this->getParameter('exportnowrap'))
178179 return new ApiFormatRaw($this->getMain());
179180 else
180181 return null;
@@ -556,7 +557,7 @@
557558 'redirects' => 'Automatically resolve redirects',
558559 'indexpageids' => 'Include an additional pageids section listing all returned page IDs.',
559560 'export' => 'Export the current revisions of all given or generated pages',
560 - 'exportnowrap' => 'Return the export XML without wrapping it in an XML result',
 561+ 'exportnowrap' => 'Return the export XML without wrapping it in an XML result. Can only be used with export',
561562 );
562563 }
563564

Follow-up revisions

RevisionCommit summaryAuthorDate
r48629* API: Really fix bug 17673 this time: exportnowrap still returned fatal erro...catrope11:40, 20 March 2009

Status & tagging log