r47702 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47701‎ | r47702 | r47703 >
Date:11:36, 23 February 2009
Author:jojo
Status:ok (Comments)
Tags:
Comment:
use a pattern instead, is the more general solution.
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)
  • /trunk/extensions/Collection/Collection.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.i18n.php
@@ -30,7 +30,7 @@
3131 'coll-exclusion_category_title' => 'Exclude in print',
3232 'coll-template_blacklist_title' => 'MediaWiki:PDF Template Blacklist', # do not translate or duplicate this message to other languages
3333 'coll-print_template_prefix' => 'Print',
34 - 'coll-print_template_subpage' => 'Print',
 34+ 'coll-print_template_pattern' => '$1/Print',
3535 'coll-create_a_book' => 'Create a book',
3636 'coll-add_page' => 'Add wiki page',
3737 'coll-remove_page' => 'Remove wiki page',
@@ -988,7 +988,7 @@
989989 'coll-collections' => 'Bücher',
990990 'coll-exclusion_category_title' => 'Vom Druck ausschließen',
991991 'coll-print_template_prefix' => 'Drucken',
992 - 'coll-print_template_subpage' => 'Druck',
 992+ 'coll-print_template_subpage' => '$1/Druck',
993993 'coll-create_a_book' => 'Buch erstellen',
994994 'coll-add_page' => 'Wikiseite hinzufügen',
995995 'coll-remove_page' => 'Wikiseite entfernen',
Index: trunk/extensions/Collection/Collection.body.php
@@ -717,7 +717,7 @@
718718 'template_blacklist' => wfMsgForContent( 'coll-template_blacklist_title' ),
719719 'template_exclusion_category' => wfMsgForContent( 'coll-exclusion_category_title' ),
720720 'print_template_prefix' => wfMsgForContent( 'coll-print_template_prefix' ),
721 - 'print_template_subpage' => wfMsgForContent( 'coll-print_template_subbpage' ),
 721+ 'print_template_pattern' => wfMsgForContent( 'coll-print_template_pattern' ),
722722 'language' => $wgContLang->getCode(),
723723 'writer' => $writer,
724724 ) );
@@ -754,7 +754,7 @@
755755 'template_blacklist' => wfMsgForContent( 'coll-template_blacklist_title' ),
756756 'template_exclusion_category' => wfMsgForContent( 'coll-exclusion_category_title' ),
757757 'print_template_prefix' => wfMsgForContent( 'coll-print_template_prefix' ),
758 - 'print_template_subpage' => wfMsgForContent( 'coll-print_template_subpage' ),
 758+ 'print_template_pattern' => wfMsgForContent( 'coll-print_template_pattern' ),
759759 'language' => $wgContLang->getCode(),
760760 'writer' => $writer,
761761 'force_render' => true
@@ -910,7 +910,7 @@
911911 'template_blacklist' => wfMsgForContent( 'coll-template_blacklist_title' ),
912912 'template_exclusion_category' => wfMsgForContent( 'coll-exclusion_category_title' ),
913913 'print_template_prefix' => wfMsgForContent( 'coll-print_template_prefix' ),
914 - 'print_template_subpage' => wfMsgForContent( 'coll-print_template_subpage' ),
 914+ 'print_template_pattern' => wfMsgForContent( 'coll-print_template_pattern' ),
915915 'pod_api_url' => $this->mPODPartners[$partner]['posturl'],
916916 ) );
917917 if ( !$response ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r47703Follow up r47702: rename message for 'de' tooraymond11:39, 23 February 2009

Comments

#Comment by Raymond (talk | contribs)   11:46, 23 February 2009

'de' message renamed in r47703.

But what is $1?

 wfMsgForContent( 'coll-print_template_pattern' )

does not has a parameter.

Status & tagging log