r47664 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47663‎ | r47664 | r47665 >
Date:14:35, 22 February 2009
Author:aaron
Status:ok
Tags:
Comment:
Stylistic code tweaks
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -329,7 +329,7 @@
330330 span.mw-revdelundel-link,
331331 strong.mw-revdelundel-link {
332332 font-family: monospace;
333 - font-size: smaller
 333+ font-size: smaller;
334334 }
335335
336336 /* feed links */
Index: trunk/phase3/includes/Linker.php
@@ -1783,9 +1783,7 @@
17841784 # FIXME: Per standard MW behavior, a value of '-' means to suppress the
17851785 # attribute, but this is broken for accesskey: that might be a useful
17861786 # value.
1787 - if( $accesskey != ''
1788 - && $accesskey != '-'
1789 - && !wfEmptyMsg( "accesskey-$name", $accesskey ) ) {
 1787+ if( $accesskey != '' && $accesskey != '-' && !wfEmptyMsg( "accesskey-$name", $accesskey ) ) {
17901788 wfProfileOut( __METHOD__ );
17911789 return $accesskey;
17921790 }
@@ -1806,9 +1804,7 @@
18071805 public function revDeleteLink( $query = array(), $restricted = false ) {
18081806 $sp = SpecialPage::getTitleFor( 'Revisiondelete' );
18091807 $text = wfMsgHtml( 'rev-delundel' );
1810 - $tag = 'span';
1811 - if( $restricted )
1812 - $tag = 'strong';
 1808+ $tag = $restricted ? 'strong' : 'span';
18131809 $link = $this->link( $sp, $text, array(), $query, array( 'known', 'noclasses' ) );
18141810 return Xml::tags( $tag, array( 'class' => 'mw-revdelundel-link' ), "($link)" );
18151811 }

Status & tagging log