r47611 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47610‎ | r47611 | r47612 >
Date:12:44, 21 February 2009
Author:catrope
Status:ok
Tags:
Comment:
API: Fix up r47470: User::newFromRow() needs all rows from the User table. This kills lots of warnings and really fixes bug 17561
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryUsers.php
@@ -78,10 +78,8 @@
7979 {
8080 $db = $this->getDb();
8181 $this->addTables('user', 'u1');
82 - $this->addFields('u1.user_name');
 82+ $this->addFields('u1.*');
8383 $this->addWhereFld('u1.user_name', $goodNames);
84 - $this->addFieldsIf('u1.user_editcount', isset($this->prop['editcount']));
85 - $this->addFieldsIf('u1.user_registration', isset($this->prop['registration']));
8684
8785 if(isset($this->prop['groups'])) {
8886 $this->addTables('user_groups');

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47470API: (bug 17561) Recommit r44231 ("Added usprop=emailable to list=users"), wh...catrope22:31, 18 February 2009

Status & tagging log