r47587 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47586‎ | r47587 | r47588 >
Date:21:02, 20 February 2009
Author:brion
Status:ok
Tags:
Comment:
Add type hint on newFromStable() so we'll get a better whinge when it's called with bogus input
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevision.php
@@ -104,7 +104,7 @@
105105 * @param int $flags
106106 * @returns mixed FlaggedRevision (null on failure)
107107 */
108 - public static function newFromStable( $title, $flags = 0 ) {
 108+ public static function newFromStable( Title $title, $flags = 0 ) {
109109 $columns = self::selectFields();
110110 # If we want the text, then get the text flags too
111111 if( $flags & FR_TEXT ) {

Status & tagging log