r47554 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47553‎ | r47554 | r47555 >
Date:14:13, 20 February 2009
Author:simetrical
Status:ok
Tags:
Comment:
Fix completely broken profiling change

Thanks, Ialex. :)
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -869,19 +869,21 @@
870870 public function getLinkUrl( $query = array(), $variant = false ) {
871871 wfProfileIn( __METHOD__ );
872872 if( !is_array( $query ) ) {
 873+ wfProfileOut( __METHOD__ );
873874 throw new MWException( 'Title::getLinkUrl passed a non-array for '.
874875 '$query' );
875876 }
876877 if( $this->isExternal() ) {
877 - return $this->getFullURL( $query );
 878+ $ret = $this->getFullURL( $query );
878879 } elseif( $this->getPrefixedText() === ''
879880 and $this->getFragment() !== '' ) {
880 - return $this->getFragmentForURL();
 881+ $ret = $this->getFragmentForURL();
881882 } else {
882 - return $this->getLocalURL( $query, $variant )
 883+ $ret = $this->getLocalURL( $query, $variant )
883884 . $this->getFragmentForURL();
884885 }
885886 wfProfileOut( __METHOD__ );
 887+ return $ret;
886888 }
887889
888890 /**

Status & tagging log