r47539 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47538‎ | r47539 | r47540 >
Date:11:09, 20 February 2009
Author:simetrical
Status:ok
Tags:
Comment:
Profile Title::getLinkUrl()

Linker::linkUrl() is >100us, it seems, and a lot of that might be
Title::getLinkUrl(). (RC on enwiki with 500 rows takes 6s to generate,
and 2s is spent on Linker::link().)
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -867,6 +867,7 @@
868868 * @return \type{\string} the URL
869869 */
870870 public function getLinkUrl( $query = array(), $variant = false ) {
 871+ wfProfileIn( __METHOD__ );
871872 if( !is_array( $query ) ) {
872873 throw new MWException( 'Title::getLinkUrl passed a non-array for '.
873874 '$query' );
@@ -880,6 +881,7 @@
881882 return $this->getLocalURL( $query, $variant )
882883 . $this->getFragmentForURL();
883884 }
 885+ wfProfileOut( __METHOD__ );
884886 }
885887
886888 /**

Status & tagging log