r47512 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47511‎ | r47512 | r47513 >
Date:20:21, 19 February 2009
Author:ialex
Status:ok
Tags:
Comment:
(bug 17570) $wgMaxRedirects is now correctly respected when following redirects (was previously one more than $wgMaxRedirects)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -339,7 +339,7 @@
340340 // recursive check to follow double redirects
341341 $recurse = $wgMaxRedirects;
342342 $titles = array( $title );
343 - while( --$recurse >= 0 ) {
 343+ while( --$recurse > 0 ) {
344344 if( $title->isRedirect() ) {
345345 $article = new Article( $title, 0 );
346346 $newtitle = $article->getRedirectTarget();
Index: trunk/phase3/RELEASE-NOTES
@@ -195,6 +195,8 @@
196196 * (bug 17556) <link> parameters in Special:Contributions feeds (RSS and Atom)
197197 now point to the actual contributors' feed.
198198 * ForeignApiRepos now fetch MIME types, rather than trying to figure it locally
 199+* (bug 17570) $wgMaxRedirects is now correctly respected when following
 200+ redirects (was previously one more than $wgMaxRedirects)
199201
200202 == API changes in 1.15 ==
201203 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Status & tagging log