r47443 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47442‎ | r47443 | r47444 >
Date:10:53, 18 February 2009
Author:jojo
Status:ok
Tags:
Comment:
do not use Ajax callback to clear collection to prevent wrong "add link" (i.e. "Add wiki page" instead of "Add category")
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -1194,7 +1194,7 @@
11951195 $msg = htmlspecialchars( wfMsg( 'coll-clear_collection_confirm' ) );
11961196 $out .= <<<EOS
11971197 <li>
1198 - <a href="$href" onclick="if (confirm('$msg')) collectionCall('Clear', []); return false;" rel="nofollow">$clearCollection</a>
 1198+ <a href="$href" onclick="if (confirm('$msg')) return true; else return false;" rel="nofollow">$clearCollection</a>
11991199 </li>
12001200 EOS
12011201 ;

Status & tagging log