r47420 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47419‎ | r47420 | r47421 >
Date:05:17, 18 February 2009
Author:werdna
Status:deferred
Tags:
Comment:
Fix accidental regression of 'summary' message to text-only.
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1344,7 +1344,7 @@
13451345 $commentsubject = '';
13461346 if ( !$wgRequest->getBool( 'nosummary' ) ) {
13471347 $commentsubject =
1348 - Xml::label( $subject, 'wpSummary' );
 1348+ Xml::element( 'label', array( 'for' => 'wpSummary' ), $subject );
13491349 $commentsubject =
13501350 Xml::tags( 'span', array( 'id' => 'wpSummaryLabel' ), $commentsubject );
13511351 $commentsubject .= ' ';
@@ -1365,7 +1365,7 @@
13661366 } else {
13671367 $commentsubject = '';
13681368
1369 - $editsummary = Xml::label( $summary, 'wpSummary' );
 1369+ $editsummary = Xml::element( 'label', array( 'for' => 'wpSummary' ), $summary );
13701370 $editsummary =
13711371 Xml::tags( 'span', array( 'id' => 'wpSummaryLabel' ), $editsummary );
13721372

Status & tagging log