r47366 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47365‎ | r47366 | r47367 >
Date:17:05, 17 February 2009
Author:kim
Status:deferred
Tags:
Comment:
bugfix. Program was (unintentionally) re-using old
Installer objects for new installations. Occaisionally data from an old
installation would be used, instead of the defaults set by __init__.
This would lead to the program uninstalling the wrong wiki.
Modified paths:
  • /trunk/wikiation/installer/installers.py (modified) (history)

Diff [purge]

Index: trunk/wikiation/installer/installers.py
@@ -273,15 +273,12 @@
274274 print "Cannot find '"+system_name+"' in the list of supported installation systems."
275275 return None
276276 else:
277 - system=systems[system_name]
 277+ sYstem=systems[system_name]
278278
279 - return systems[system_name]
 279+ return sYstem()
280280
281 -
 281+systems={'wikiation_toolkit':Toolkit_Installer,'extension': Extension_Installer, 'mediawiki':Mediawiki_Installer}
282282
283 -systems={'wikiation_toolkit':Toolkit_Installer(),'extension': Extension_Installer(), 'mediawiki':Mediawiki_Installer()}
284 -
285 -
286283 if __name__=="__main__":
287284 print "testing installers.py module"
288285 print "CTRL-C to abort. run installer.py to actually use the installer"

Status & tagging log