r47340 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47339‎ | r47340 | r47341 >
Date:22:37, 16 February 2009
Author:kim
Status:deferred
Tags:
Comment:
License information
Modified paths:
  • /trunk/wiki/wikiation/installer/LICENSE (modified) (history)
  • /trunk/wiki/wikiation/installer/extension_installer.py (modified) (history)
  • /trunk/wiki/wikiation/installer/installation_system.py (modified) (history)
  • /trunk/wiki/wikiation/installer/installer.py (modified) (history)
  • /trunk/wiki/wikiation/installer/installer_util.py (modified) (history)
  • /trunk/wiki/wikiation/installer/installers.py (modified) (history)
  • /trunk/wiki/wikiation/installer/isolation.py (modified) (history)
  • /trunk/wiki/wikiation/installer/mediawiki_installer.py (modified) (history)

Diff [purge]

Index: trunk/wiki/wikiation/installer/extension_installer.py
@@ -1,3 +1,8 @@
 2+# This software, copyright (C) 2008-2009 by Wikiation.
 3+# This software is developed by Kim Bruning.
 4+#
 5+# Distributed under the terms of the MIT license.
 6+
27 import settings
38 import os, os.path, shutil
49 import subprocess
Index: trunk/wiki/wikiation/installer/installer_util.py
@@ -1,3 +1,8 @@
 2+# This software, copyright (C) 2008-2009 by Wikiation.
 3+# This software is developed by Kim Bruning.
 4+#
 5+# Distributed under the terms of the MIT license.
 6+
27 import sys
38
49 def replace_generic(replacements,infilename,outfilename):
Index: trunk/wiki/wikiation/installer/LICENSE
@@ -1,9 +1,21 @@
2 -license notes...
 2+This software, copyright (C) 2008-2009 by Wikiation. This software is developed by Kim Bruning.
33
4 -copyright holder (C) www.wikiation.nl (kvk nr) 2008
 4+Permission is hereby granted, free of charge, to any person obtaining a copy
 5+of this software and associated documentation files (the "Software"), to deal
 6+in the Software without restriction, including without limitation the rights to
 7+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
 8+of the Software, and to permit persons to whom the Software is furnished to do
 9+so, subject to the following conditions:
510
6 -Code is GPL v3 or later
7 -Logo.png itself is a wikiation trademark and is (C) wikiation, all rights reserved (same as the wikimedia or wikipedia logos)
 11+The above copyright notice and this permission notice shall be included in all
 12+copies or substantial portions of the Software.
813
 14+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 15+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 16+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 17+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 18+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 19+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 20+SOFTWARE.
921
10 -(replace actual license text here)
 22+
Index: trunk/wiki/wikiation/installer/installer.py
@@ -1,4 +1,10 @@
22 #!/usr/bin/python
 3+
 4+# This software, copyright (C) 2008-2009 by Wikiation.
 5+# This software is developed by Kim Bruning.
 6+#
 7+# Distributed under the terms of the MIT license.
 8+
39 import sys,os, os.path
410 import readline
511 import re
Index: trunk/wiki/wikiation/installer/installers.py
@@ -1,3 +1,8 @@
 2+# This software, copyright (C) 2008-2009 by Wikiation.
 3+# This software is developed by Kim Bruning.
 4+#
 5+# Distributed under the terms of the MIT license.
 6+
27 import settings
38 import os, os.path, shutil
49 import subprocess
Index: trunk/wiki/wikiation/installer/mediawiki_installer.py
@@ -1,3 +1,7 @@
 2+# This software is developed by Kim Bruning.
 3+#
 4+# Distributed under the terms of the MIT license.
 5+
26 import settings
37 import os, os.path, shutil
48 import subprocess
@@ -7,7 +11,8 @@
812 from installer_util import *
913 from isolation import *
1014
11 -#this still uses some legacy structured code, wrapped in a class so it can't do too much harm outside this file. Will refactor later when I have more time.
 15+# this still uses some legacy structured code, wrapped in a class so it can't do
 16+#too much harm outside this file. Will refactor later when I have more time.
1217
1318 # already partially refactored while creating class.
1419
@@ -19,6 +24,7 @@
2025
2126
2227 class Mediawiki_Installer(Installation_System):
 28+ """installer for mediawiki revisions"""
2329 system_name='mediawiki_installer'
2430 # TODO: destination_dir isn't quite changable until we have finished refactoring everything (not today)
2531 destination_dir=settings.revisionsdir
@@ -74,12 +80,12 @@
7581
7682
7783
78 -#duplicate of get_installed()
 84+#duplicate of get_installed() TODO: Refactor
7985 def installed():
8086 """list installed items"""
8187 return os.listdir(settings.revisionsdir)
8288
83 -#duplicate of get_installers()
 89+#duplicate of get_installers() TODO: Refactor
8490 def available():
8591 """list available items"""
8692
Index: trunk/wiki/wikiation/installer/isolation.py
@@ -1,3 +1,8 @@
 2+# This software, copyright (C) 2008-2009 by Wikiation.
 3+# This software is developed by Kim Bruning.
 4+#
 5+# Distributed under the terms of the MIT license.
 6+
27 import sys,os, os.path
38 import settings
49
Index: trunk/wiki/wikiation/installer/installation_system.py
@@ -1,3 +1,8 @@
 2+# This software, copyright (C) 2008-2009 by Wikiation.
 3+# This software is developed by Kim Bruning.
 4+#
 5+# Distributed under the terms of the MIT license.
 6+`
27 import settings
38 import os, os.path, shutil
49 import subprocess

Status & tagging log