r47333 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47332‎ | r47333 | r47334 >
Date:19:08, 16 February 2009
Author:catrope
Status:ok
Tags:
Comment:
API: Add AS explicitly for PostgreSQL compatibility and fix hinky indentation in ApiQueryUsers. Patch by Brad Jorsch
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryUsers.php
@@ -95,7 +95,7 @@
9696 $this->addJoinConds(array(
9797 'ipblocks' => array('LEFT JOIN', 'ipb_user=u1.user_id'),
9898 $u2 => array('LEFT JOIN', 'ipb_by=u2.user_id')));
99 - $this->addFields(array('ipb_reason', 'u2.user_name blocker_name'));
 99+ $this->addFields(array('ipb_reason', 'u2.user_name AS blocker_name'));
100100 }
101101
102102 $data = array();
@@ -129,9 +129,9 @@
130130 null, $data[$u]);
131131 if(!$fit)
132132 {
133 - $this->setContinueEnumParameter('users',
134 - implode('|', array_diff($users, $done)));
135 - break;
 133+ $this->setContinueEnumParameter('users',
 134+ implode('|', array_diff($users, $done)));
 135+ break;
136136 }
137137 $done[] = $u;
138138 }

Status & tagging log