r47311 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47310‎ | r47311 | r47312 >
Date:10:08, 16 February 2009
Author:catrope
Status:ok
Tags:
Comment:
ParserFunctions: Fix undefined variable warnings introduced in r47205
Modified paths:
  • /trunk/extensions/ParserFunctions/Expr.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ParserFunctions/Expr.php
@@ -455,7 +455,7 @@
456456 $left = array_pop( $stack );
457457
458458 // Fix handling of 0.0, 0.00, etc
459 - if ($hasBC) {
 459+ if ($haveBC) {
460460 $right = bccompWithTolerance( $right, '0' ) != 0;
461461 $left = bccompWithTolerance( $left, '0' ) != 0;
462462 }
@@ -467,7 +467,7 @@
468468 $right = array_pop( $stack );
469469 $left = array_pop( $stack );
470470 // Fix handling of 0.0, 0.00, etc
471 - if ($hasBC) {
 471+ if ($haveBC) {
472472 $right = bccompWithTolerance( $right, '0' ) != 0;
473473 $left = bccompWithTolerance( $left, '0' ) != 0;
474474 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47205Fix handling of 0, 0.0, 0.00 etc in logical functions.werdna00:28, 13 February 2009

Status & tagging log