r47243 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47242‎ | r47243 | r47244 >
Date:23:51, 13 February 2009
Author:werdna
Status:deferred
Tags:
Comment:
Miscellaneous whitespace fixes, killing some lines of code commented-out with no explanation.
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/LqtDate.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/LqtHistoricalThread.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/LqtNewMessages.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/LqtPost.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/LqtQueryGroup.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/LqtThread.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/LqtThreadHistoryIterator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/LqtHistoricalThread.php
@@ -1,5 +1,4 @@
22 <?php
3 -
43 if (!defined('MEDIAWIKI')) die;
54
65 class HistoricalThread extends Thread {
@@ -63,4 +62,4 @@
6463 function isHistorical() {
6564 return true;
6665 }
67 -}
 66+}
\ No newline at end of file
Index: trunk/extensions/LiquidThreads/classes/LqtDate.php
@@ -1,5 +1,4 @@
22 <?php
3 -
43 if (!defined('MEDIAWIKI')) die;
54
65 class Date {
Index: trunk/extensions/LiquidThreads/classes/LqtNewMessages.php
@@ -1,7 +1,7 @@
22 <?php
3 -
43 if (!defined('MEDIAWIKI')) die;
54
 5+
66 class NewMessages {
77
88 static function markThreadAsUnreadByUser($thread, $user) {
@@ -91,4 +91,4 @@
9292 array(), array('user_message_state') );
9393 }
9494
95 -}
 95+}
\ No newline at end of file
Index: trunk/extensions/LiquidThreads/classes/LqtQueryGroup.php
@@ -1,5 +1,4 @@
22 <?php
3 -
43 if (!defined('MEDIAWIKI')) die;
54
65 class QueryGroup {
Index: trunk/extensions/LiquidThreads/classes/LqtThreadHistoryIterator.php
@@ -1,5 +1,4 @@
22 <?php
3 -
43 if (!defined('MEDIAWIKI')) die;
54
65 class ThreadHistoryIterator extends ArrayIterator {
@@ -32,4 +31,4 @@
3332 $this->append( HistoricalThread::fromTextRepresentation($l->hthread_contents) );
3433 }
3534 }
36 -}
 35+}
\ No newline at end of file
Index: trunk/extensions/LiquidThreads/classes/LqtPost.php
@@ -1,7 +1,7 @@
22 <?php
3 -
43 if (!defined('MEDIAWIKI')) die;
54
 5+// TODO get rid of this class. sheesh.
66 class Post extends Article {
77 /**
88 * Return the User object representing the author of the first revision
@@ -21,4 +21,4 @@
2222 else
2323 return null;
2424 }
25 -}
 25+}
\ No newline at end of file
Index: trunk/extensions/LiquidThreads/classes/LqtThread.php
@@ -1,7 +1,7 @@
22 <?php
3 -
43 if (!defined('MEDIAWIKI')) die;
54
 5+
66 class Thread {
77 /* SCHEMA changes must be reflected here. */
88
@@ -162,16 +162,9 @@
163163 'thread_parent' => $this->parentId,
164164 'thread_type' => $this->type,
165165 'thread_summary_page' => $this->summaryId,
166 -// 'thread_modified' => wfTimestampNow(),
167 -// 'thread_revision' => $this->revisionNumber,
168166 'thread_article_namespace' => $this->articleNamespace,
169167 'thread_article_title' => $this->articleTitle,
170168 'thread_editedness' => $this->editedness,
171 -// 'thread_change_type' => $this->changeType,
172 -// 'thread_change_object' => $this->changeObject,
173 -// 'thread_change_comment' => $this->changeComment,
174 -// 'thread_change_user' => $this->changeUser,
175 -// 'thread_change_user_text' => $this->changeUserText,
176169 ),
177170 /* WHERE */ array( 'thread_id' => $this->id, ),
178171 __METHOD__);
@@ -179,10 +172,6 @@
180173 if( $change_type == Threads::CHANGE_EDITED_ROOT ) {
181174 NewMessages::writeMessageStateForUpdatedThread($this);
182175 }
183 -
184 - // RecentChange::notifyEdit( wfTimestampNow(), $this->root(), /*minor*/false, $wgUser, $summary,
185 - // $lastRevision, $this->getModified(), $bot, '', $oldsize, $newsize,
186 - // $revisionId );
187176 }
188177
189178 function delete($reason) {
@@ -582,4 +571,4 @@
583572 }
584573
585574 }
586 -}
 575+}
\ No newline at end of file

Status & tagging log