r47134 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47133‎ | r47134 | r47135 >
Date:09:53, 11 February 2009
Author:mkroetzsch
Status:deferred
Tags:
Comment:
updated list printer to close Bug 17417 (some HTML triggers Tidy errors)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_QP_List.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_QP_List.php
@@ -9,8 +9,8 @@
1010 /**
1111 * New implementation of SMW's printer for results in lists.
1212 *
13 - * Somewhat confusing code, since one has to iterate through lists, inserting texts
14 - * in between their elements depending on whether the element is the first that is
 13+ * Somewhat confusing code, since one has to iterate through lists, inserting texts
 14+ * in between their elements depending on whether the element is the first that is
1515 * printed, the first that is printed in parentheses, or the last that will be printed.
1616 * Maybe one could further simplify this.
1717 *
@@ -42,7 +42,7 @@
4343 if ( ('ul' == $this->mFormat) || ('ol' == $this->mFormat) ) {
4444 $header = '<' . $this->mFormat . '>';
4545 $footer = '</' . $this->mFormat . '>';
46 - $rowstart = "\n\t<li>";
 46+ $rowstart = '<li>';
4747 $rowend = '</li>';
4848 $plainlist = false;
4949 } else {

Status & tagging log