r47127 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47126‎ | r47127 | r47128 >
Date:06:34, 11 February 2009
Author:tstarling
Status:ok
Tags:
Comment:
Don't double-parse messages, it breaks lots of things. Fixes bug #17442.
Modified paths:
  • /trunk/extensions/Cite/Cite_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/Cite_body.php
@@ -123,7 +123,7 @@
124124 return $ret;
125125 }
126126 }
127 -
 127+
128128 function guardedRef( $str, $argv, $parser, $default_group=CITE_DEFAULT_GROUP ) {
129129 $this->mParser = $parser;
130130
@@ -709,7 +709,7 @@
710710 */
711711 function setHooks() {
712712 global $wgParser, $wgHooks;
713 -
 713+
714714 $wgParser->setHook( 'ref' , array( &$this, 'ref' ) );
715715 $wgParser->setHook( 'references' , array( &$this, 'references' ) );
716716
@@ -731,7 +731,7 @@
732732 return
733733 $this->parse(
734734 '<strong class="error">' .
735 - wfMsg( 'cite_error', wfMsg( $key, $param ) ) .
 735+ wfMsgNoTrans( 'cite_error', wfMsgNoTrans( $key, $param ) ) .
736736 '</strong>'
737737 );
738738 }

Status & tagging log