r47056 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47055‎ | r47056 | r47057 >
Date:22:07, 9 February 2009
Author:raymond
Status:ok
Tags:
Comment:
* (bug 17311) Add a note beside the gender selection menu to tell users that this information will be public
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPreferences.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -402,6 +402,7 @@
403403 'gender-unknown',
404404 'gender-male',
405405 'gender-female',
 406+ 'prefs-help-gender',
406407 'email',
407408 'prefs-help-realname',
408409 'loginerror',
Index: trunk/phase3/includes/specials/SpecialPreferences.php
@@ -755,7 +755,10 @@
756756 $wgOut->addHTML(
757757 $this->tableRow(
758758 Xml::label( wfMsg( 'yourgender' ), 'wpGender' ),
759 - $gender->getHTML()
 759+ $gender->getHTML(),
 760+ Xml::tags( 'div', array( 'class' => 'prefsectiontip' ),
 761+ wfMsgExt( 'prefs-help-gender', 'parseinline' )
 762+ )
760763 )
761764 );
762765
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -916,6 +916,7 @@
917917 'gender-unknown' => 'Unspecified',
918918 'gender-male' => 'Male',
919919 'gender-female' => 'Female',
 920+'prefs-help-gender' => 'Optional: used for gender-correct addressing by the software. This information will be public.',
920921 'email' => 'E-mail',
921922 'prefs-help-realname' => 'Real name is optional.
922923 If you choose to provide it, this will be used for giving you attribution for your work.',
Index: trunk/phase3/RELEASE-NOTES
@@ -91,6 +91,8 @@
9292 * Preprocessor output now cached in memcached.
9393 * (bug 14468) Lines in classic RecentChanges and Watchlist have classes
9494 "mw-line-odd" and "mw-line-even" to make styling using css possible.
 95+* (bug 17311) Add a note beside the gender selection menu to tell users that
 96+ this information will be public
9597
9698 === Bug fixes in 1.15 ===
9799 * (bug 16968) Special:Upload no longer throws useless warnings.

Status & tagging log