r47045 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47044‎ | r47045 | r47046 >
Date:16:34, 9 February 2009
Author:demon
Status:deferred
Tags:
Comment:
Per code review, bit of cleanup to Special:Export.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialExport.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialExport.php
@@ -61,7 +61,7 @@
6262 }
6363 }
6464 }
65 - else if( $wgRequest->wasPosted() && $page == '' ) {
 65+ else if( $wgRequest->wasPosted() && $par == '' ) {
6666 $page = $wgRequest->getText( 'pages' );
6767 $this->curonly = $wgRequest->getCheck( 'curonly' );
6868 $rawOffset = $wgRequest->getVal( 'offset' );
@@ -125,7 +125,7 @@
126126 $filename = urlencode( $wgSitename . '-' . wfTimestampNow() . '.xml' );
127127 $wgRequest->response()->header( "Content-disposition: attachment;filename={$filename}" );
128128 }
129 - $this->doExport( $page, $history );
 129+ $this->doExport( $page, $history, $list_authors );
130130 return;
131131 }
132132
@@ -159,7 +159,7 @@
160160 * @param string $page User input on what page(s) to export
161161 * @param mixed $history one of the WikiExporter history export constants
162162 */
163 - private function doExport( $page, $history ) {
 163+ private function doExport( $page, $history, $list_authors ) {
164164 global $wgExportMaxHistory;
165165
166166 /* Split up the input and look up linked pages */
@@ -199,8 +199,8 @@
200200 set_time_limit(0);
201201 wfRestoreWarnings();
202202 }
203 - $exporter = new WikiExporter( $db, $history, $buffer );
204 - $exporter->list_authors = $list_authors ;
 203+ $exporter = new WikiExporter( $db, $history, $buffer );
 204+ $exporter->list_authors = $list_authors;
205205 $exporter->openStream();
206206 foreach( $pages as $page ) {
207207 /*

Status & tagging log