r47042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47041‎ | r47042 | r47043 >
Date:15:15, 9 February 2009
Author:catrope
Status:deferred
Tags:
Comment:
Remove a TODO from ApiMove and add a FIXME to SpecialMovepage
Modified paths:
  • /trunk/phase3/includes/api/ApiMove.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiMove.php
@@ -107,7 +107,6 @@
108108 $r['subpages'] = $this->moveSubpages($fromTitle, $toTitle,
109109 $params['reason'], $params['noredirect']);
110110 $this->getResult()->setIndexedTagName($r['subpages'], 'subpage');
111 - // TODO: Should we move talk subpages if moving the talk page failed?
112111 if($params['movetalk'])
113112 {
114113 $r['subpages-talk'] = $this->moveSubpages($fromTalk, $toTalk,
Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -378,6 +378,8 @@
379379 # would mean that you couldn't move them back in one operation, which
380380 # is bad. FIXME: A specific error message should be given in this
381381 # case.
 382+
 383+ // FIXME: Use Title::moveSubpages() here
382384 $dbr = wfGetDB( DB_MASTER );
383385 if( $this->moveSubpages && (
384386 MWNamespace::hasSubpages( $nt->getNamespace() ) || (

Status & tagging log