r47040 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47039‎ | r47040 | r47041 >
Date:14:31, 9 February 2009
Author:siebrand
Status:deferred
Tags:
Comment:
* remove forgotten case of hard coded pipe separator in Pager
* fix bug in GlobalFunctions.php introduced in r47028. pipeList() needs to be fed an array.
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/Pager.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -986,11 +986,11 @@
987987 } else {
988988 $nlink = '<a href="' . $title->escapeLocalUrl( $q ) . "\" class=\"mw-nextlink\">{$next}</a>";
989989 }
990 - $nums = $wgLang->pipeList( wfNumLink( $offset, 20, $title, $query ),
 990+ $nums = $wgLang->pipeList( array( wfNumLink( $offset, 20, $title, $query ),
991991 wfNumLink( $offset, 50, $title, $query ),
992992 wfNumLink( $offset, 100, $title, $query ),
993993 wfNumLink( $offset, 250, $title, $query ),
994 - wfNumLink( $offset, 500, $title, $query ) );
 994+ wfNumLink( $offset, 500, $title, $query ) ) );
995995
996996 return wfMsg( 'viewprevnext', $plink, $nlink, $nums );
997997 }
Index: trunk/phase3/includes/Pager.php
@@ -533,7 +533,7 @@
534534 $limits = $wgLang->pipeList( $limitLinks );
535535
536536 $this->mNavigationBar =
537 - "({$pagingLinks['first']} | {$pagingLinks['last']}) " .
 537+ "(" . $wgLang->pipeList( array( $pagingLinks['first'], $pagingLinks['last'] ) ) . ") " .
538538 wfMsgHtml( 'viewprevnext', $pagingLinks['prev'],
539539 $pagingLinks['next'], $limits );
540540

Follow-up revisions

RevisionCommit summaryAuthorDate
r47046(bug 7509) Separation strings should be configurable...siebrand17:48, 9 February 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47028* Update message 'pipe-separator' to have leading and trailing space for Engl...siebrand09:13, 9 February 2009

Status & tagging log